Page MenuHomePhabricator
Differential D21064

Remove duplication of XHPAST version in PHP and C code
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:04 PM.
Tags
None
Referenced Files
F14805709: D21064.id50189.diff
Sat, Jan 25, 9:17 PM
F14805321: D21064.diff
Sat, Jan 25, 8:04 PM
Unknown Object (File)
Thu, Jan 23, 1:24 AM
Unknown Object (File)
Tue, Jan 21, 12:38 PM
Unknown Object (File)
Sat, Jan 18, 4:47 AM
Unknown Object (File)
Fri, Jan 17, 12:25 PM
Unknown Object (File)
Mon, Jan 13, 12:29 PM
Unknown Object (File)
Mon, Jan 6, 5:17 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits
rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code
Summary

Depends on D21063. Ref T13492. Currently, XHPAST defines a version in both PHP code and C code, and they must be kept in sync.

Switch to a single definition in PHP, then carry it through the build pipeline into C.

Test Plan

Did a clean rebuild of XHPAST, saw a version number carried in from PHP. Ran "xhpast --version".

Diff Detail

Repository
rARC Arcanist
Branch
xhpast2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24002
Build 33034: Run Core Tests
Build 33033: arc lint + arc unit

Revision Contents
Changeset List

PathSize
support/
xhpast/
5 lines
bin/
xhpast-generate-nodes.php
generate_nodes.php
21 lines
bin/
8 lines
7 lines

Diff 50183

View Options

support/xhpast/Makefile

Loading...
View Options

support/xhpast/bin/xhpast-generate-nodes.php

Loading...
View Options

support/xhpast/bin/xhpast-generate-version.php

Loading...
View Options

support/xhpast/generate_nodes.php

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility