Page MenuHomePhabricator
Differential D21064

Remove duplication of XHPAST version in PHP and C code
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:04 PM.
Tags
None
Referenced Files
F13097116: D21064.diff
Thu, Apr 25, 9:10 PM
Unknown Object (File)
Wed, Apr 10, 1:15 AM
Unknown Object (File)
Tue, Apr 9, 12:26 AM
Unknown Object (File)
Sun, Mar 31, 10:00 PM
Unknown Object (File)
Feb 17 2024, 2:27 PM
Unknown Object (File)
Jan 21 2024, 4:46 PM
Unknown Object (File)
Jan 18 2024, 9:00 PM
Unknown Object (File)
Jan 7 2024, 4:56 PM
View All 88 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits
rARC6d15c6ea4869: Remove duplication of XHPAST version in PHP and C code
Summary

Depends on D21063. Ref T13492. Currently, XHPAST defines a version in both PHP code and C code, and they must be kept in sync.

Switch to a single definition in PHP, then carry it through the build pipeline into C.

Test Plan

Did a clean rebuild of XHPAST, saw a version number carried in from PHP. Ran "xhpast --version".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
support/
xhpast/
5 lines
bin/
xhpast-generate-nodes.php
generate_nodes.php
21 lines
bin/
8 lines
7 lines

Diff 50189

View Options

support/xhpast/Makefile

Loading...
View Options

support/xhpast/bin/xhpast-generate-nodes.php

Loading...
View Options

support/xhpast/bin/xhpast-generate-version.php

Loading...
View Options

support/xhpast/generate_nodes.php

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility