Resolve all futures inside FutureIterator
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 7:34 PM.

Tags

None

Referenced Files

	F18782412: D21033.id50103.diff
	Mon, Oct 13, 1:29 AM

	F18782411: D21033.id50102.diff
	Mon, Oct 13, 1:29 AM

	F18781721: D21033.diff
	Sun, Oct 12, 11:23 PM

	F18780549: D21033.id.diff
	Sun, Oct 12, 5:11 PM

	F18773200: D21033.diff
	Thu, Oct 9, 8:06 AM

	F18756190: D21033.id50102.diff
	Sun, Oct 5, 9:57 AM

	F18746623: D21033.id50139.diff
	Fri, Oct 3, 12:58 PM

	F18734170: D21033.id.diff
	Tue, Sep 30, 10:49 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARCe20dce875cf2: Resolve all futures inside FutureIterator

Summary

Depends on D21032. Ref T11968. Currently, "Future" and "FutureIterator" can both resolve futures.

Treat "Future->resolve()" as sugar on resolving an iterator of size 1.

Test Plan

Ran tests, created this revision.

Diff Detail

Repository

rARC Arcanist

Branch

fx3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23923
Build 32921: Run Core Tests
Build 32920: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 26 2020, 7:34 PM

Harbormaster completed remote builds in B23923: Diff 50102.Feb 26 2020, 7:35 PM

epriestley requested review of this revision.Feb 26 2020, 7:35 PM

Also remove uncalled "checkException()" method.

Harbormaster completed remote builds in B23924: Diff 50103.Feb 26 2020, 7:41 PM

epriestley added a child revision: D21034: Make the "result" property on Future private.Feb 26 2020, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2020, 5:18 PM

Closed by commit rARCe20dce875cf2: Resolve all futures inside FutureIterator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe20dce875cf2: Resolve all futures inside FutureIterator.

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

71 lines

FutureIterator.php

60 lines

Diff 50102

View Options

src/future/Future.php