Page MenuHomePhabricator

Restore old expanded include path rules for workflows which fall through
ClosedPublic

Authored by epriestley on Feb 17 2020, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 2:57 PM
Unknown Object (File)
Fri, May 3, 3:14 AM
Unknown Object (File)
Thu, May 2, 4:54 AM
Unknown Object (File)
Mon, Apr 29, 2:43 PM
Unknown Object (File)
Mon, Apr 29, 6:46 AM
Unknown Object (File)
Thu, Apr 25, 1:57 AM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Sat, Apr 20, 5:05 PM
Subscribers
None

Details

Summary

Ref T13490. Historically, "arc" was eager to load external libraries from many locations. I plan to make this significantly more structured/safer in the future (see T5055), but this rule got dropped as the "experimental" and "wilds" branches collapsed to "master".

Restore "next to arcanist" and "inside externals/includes" as valid search locations for classic workflows.

Test Plan

Ran "arc" commands in a working copy with a "load" library configured.

Diff Detail

Repository
rARC Arcanist
Branch
path1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23867
Build 32836: Run Core Tests
Build 32835: arc lint + arc unit