Page MenuHomePhabricator

Restore old expanded include path rules for workflows which fall through
ClosedPublic

Authored by epriestley on Feb 17 2020, 5:12 PM.
Tags
None
Referenced Files
F18377464: D21004.id.diff
Thu, Aug 28, 1:02 PM
F18367947: D21004.id50044.diff
Thu, Aug 28, 12:18 AM
F18366494: D21004.id50042.diff
Wed, Aug 27, 10:22 PM
F18366308: D21004.diff
Wed, Aug 27, 10:10 PM
F18364039: D21004.id50042.diff
Wed, Aug 27, 6:03 PM
F18363951: D21004.id50044.diff
Wed, Aug 27, 5:51 PM
F18363803: D21004.diff
Wed, Aug 27, 5:25 PM
F18363488: D21004.id.diff
Wed, Aug 27, 4:40 PM
Subscribers
None

Details

Summary

Ref T13490. Historically, "arc" was eager to load external libraries from many locations. I plan to make this significantly more structured/safer in the future (see T5055), but this rule got dropped as the "experimental" and "wilds" branches collapsed to "master".

Restore "next to arcanist" and "inside externals/includes" as valid search locations for classic workflows.

Test Plan

Ran "arc" commands in a working copy with a "load" library configured.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable