Page MenuHomePhabricator
Differential D21003

Try to load arcanist libraries that are checked out alongside arcanist
AbandonedPublic
Actions

Authored by solarnz on Feb 17 2020, 6:19 AM.
Tags
None
Referenced Files
F18375353: D21003.diff
Thu, Aug 28, 9:52 AM
F18366478: D21003.id50041.diff
Wed, Aug 27, 10:22 PM
F18365469: D21003.diff
Wed, Aug 27, 9:00 PM
F18364079: D21003.id50041.diff
Wed, Aug 27, 6:10 PM
F18363664: D21003.diff
Wed, Aug 27, 5:05 PM
F18100887: D21003.diff
Sat, Aug 9, 12:09 PM
F18049940: D21003.id50041.diff
Sun, Aug 3, 5:56 PM
F17869478: D21003.diff
Jul 28 2025, 11:27 AM
View All 96 Files
Subscribers
epriestley
joshuaspence
This revision can not be accepted until the required legal agreements have been signed.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

This tries to emulate the old libphutil resolution rules to
include libraries alongside the arcanist directory

This attempts to fix the issue at https://discourse.phabricator-community.org/t/arcanist-library-loading-behavior-has-changed/3541

Test Plan

Ran this locally, and it is picking up the custom library we
use internally at Freelancer.com, that we check out alongside the
arcanist repository

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorscripts/arcanist.php:563XHP5Use of Undeclared Variable
Errorscripts/arcanist.php:573XHP5Use of Undeclared Variable
Errorscripts/arcanist.php:597XHP5Use of Undeclared Variable
Unit
No Test Coverage
Build Status
Buildable 23866
Build 32834: arc lint + arc unit

Event Timeline

solarnz created this revision.Feb 17 2020, 6:19 AM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 17 2020, 6:19 AM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
solarnz requested review of this revision.Feb 17 2020, 6:19 AM
Harbormaster completed remote builds in B23866: Diff 50041.Feb 17 2020, 6:19 AM
solarnz added a subscriber: joshuaspence.Feb 17 2020, 6:24 AM

@epriestley, I believe Freelancer.com has already signed the Corporate CLA, cc @joshuaspence

epriestley added a comment.Feb 17 2020, 4:50 PM

I don't have a Freelancer CLA on file. (This is near the top of my queue of things to fix anyway so it's probably moot.)

epriestley added a comment.Feb 17 2020, 5:12 PM

This is likely fixed, at least for the moment, by D21004.

solarnz abandoned this revision.Feb 17 2020, 10:23 PM

Yep, D21004 seems to have done the job

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.
Phabricator · Built by Phacility