Page MenuHomePhabricator

Try to load arcanist libraries that are checked out alongside arcanist
AbandonedPublic

Authored by solarnz on Feb 17 2020, 6:19 AM.
This revision can not be accepted until the required legal agreements have been signed.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

This tries to emulate the old libphutil resolution rules to
include libraries alongside the arcanist directory

This attempts to fix the issue at https://discourse.phabricator-community.org/t/arcanist-library-loading-behavior-has-changed/3541

Test Plan

Ran this locally, and it is picking up the custom library we
use internally at Freelancer.com, that we check out alongside the
arcanist repository

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint ErrorsExcuse: I didn't touch this code
SeverityLocationCodeMessage
Errorscripts/arcanist.php:563XHP5Use of Undeclared Variable
Errorscripts/arcanist.php:573XHP5Use of Undeclared Variable
Errorscripts/arcanist.php:597XHP5Use of Undeclared Variable
Unit
No Unit Test Coverage
Build Status
Buildable 23866
Build 32834: arc lint + arc unit

Event Timeline

solarnz created this revision.Feb 17 2020, 6:19 AM
solarnz requested review of this revision.Feb 17 2020, 6:19 AM

@epriestley, I believe Freelancer.com has already signed the Corporate CLA, cc @joshuaspence

I don't have a Freelancer CLA on file. (This is near the top of my queue of things to fix anyway so it's probably moot.)

This is likely fixed, at least for the moment, by D21004.

solarnz abandoned this revision.Feb 17 2020, 10:23 PM

Yep, D21004 seems to have done the job

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.