Page MenuHomePhabricator

Restore old expanded include path rules for workflows which fall through
ClosedPublic

Authored by epriestley on Feb 17 2020, 5:12 PM.
Tags
None
Referenced Files
F19897521: D21004.diff
Sun, Mar 29, 8:17 AM
F19882427: D21004.diff
Thu, Mar 19, 2:19 PM
F19840761: D21004.id.diff
Wed, Mar 11, 7:44 PM
F19840584: D21004.id.diff
Wed, Mar 11, 7:19 PM
F19510134: D21004.diff
Jan 11 2026, 5:07 AM
F19004075: D21004.id.diff
Nov 21 2025, 10:23 AM
F18995279: D21004.diff
Nov 19 2025, 4:54 PM
F18945211: D21004.diff
Nov 11 2025, 5:54 PM
Subscribers
None

Details

Summary

Ref T13490. Historically, "arc" was eager to load external libraries from many locations. I plan to make this significantly more structured/safer in the future (see T5055), but this rule got dropped as the "experimental" and "wilds" branches collapsed to "master".

Restore "next to arcanist" and "inside externals/includes" as valid search locations for classic workflows.

Test Plan

Ran "arc" commands in a working copy with a "load" library configured.

Diff Detail

Repository
rARC Arcanist
Branch
path1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23867
Build 32836: Run Core Tests
Build 32835: arc lint + arc unit