Page MenuHomePhabricator

Restore old expanded include path rules for workflows which fall through
ClosedPublic

Authored by epriestley on Feb 17 2020, 5:12 PM.
Tags
None
Referenced Files
F15365121: D21004.diff
Tue, Mar 11, 1:50 PM
Unknown Object (File)
Wed, Feb 26, 11:47 AM
Unknown Object (File)
Feb 9 2025, 8:43 AM
Unknown Object (File)
Feb 9 2025, 8:43 AM
Unknown Object (File)
Feb 9 2025, 8:43 AM
Unknown Object (File)
Feb 8 2025, 10:52 AM
Unknown Object (File)
Jan 29 2025, 10:03 PM
Unknown Object (File)
Jan 28 2025, 5:28 AM
Subscribers
None

Details

Summary

Ref T13490. Historically, "arc" was eager to load external libraries from many locations. I plan to make this significantly more structured/safer in the future (see T5055), but this rule got dropped as the "experimental" and "wilds" branches collapsed to "master".

Restore "next to arcanist" and "inside externals/includes" as valid search locations for classic workflows.

Test Plan

Ran "arc" commands in a working copy with a "load" library configured.

Diff Detail

Repository
rARC Arcanist
Branch
path1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23867
Build 32836: Run Core Tests
Build 32835: arc lint + arc unit