Page MenuHomePhabricator

Restore old expanded include path rules for workflows which fall through
ClosedPublic

Authored by epriestley on Feb 17 2020, 5:12 PM.
Tags
None
Referenced Files
F15408306: D21004.diff
Tue, Mar 18, 10:21 PM
F15408161: D21004.id50042.diff
Tue, Mar 18, 9:29 PM
F15407928: D21004.id50042.diff
Tue, Mar 18, 8:16 PM
F15407674: D21004.id50042.diff
Tue, Mar 18, 6:55 PM
F15407472: D21004.id50042.diff
Tue, Mar 18, 5:40 PM
F15407227: D21004.id50042.diff
Tue, Mar 18, 4:26 PM
F15407013: D21004.id50042.diff
Tue, Mar 18, 3:12 PM
F15406799: D21004.id50042.diff
Tue, Mar 18, 1:56 PM
Subscribers
None

Details

Summary

Ref T13490. Historically, "arc" was eager to load external libraries from many locations. I plan to make this significantly more structured/safer in the future (see T5055), but this rule got dropped as the "experimental" and "wilds" branches collapsed to "master".

Restore "next to arcanist" and "inside externals/includes" as valid search locations for classic workflows.

Test Plan

Ran "arc" commands in a working copy with a "load" library configured.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable