Page MenuHomePhabricator

Restore old expanded include path rules for workflows which fall through
ClosedPublic

Authored by epriestley on Feb 17 2020, 5:12 PM.
Tags
None
Referenced Files
F19510134: D21004.diff
Sun, Jan 11, 5:07 AM
F19004075: D21004.id.diff
Nov 21 2025, 10:23 AM
F18995279: D21004.diff
Nov 19 2025, 4:54 PM
F18945211: D21004.diff
Nov 11 2025, 5:54 PM
F18857167: D21004.id.diff
Nov 1 2025, 1:34 PM
F18853805: D21004.diff
Oct 31 2025, 7:37 PM
F18716784: D21004.diff
Sep 29 2025, 12:43 PM
F18705844: D21004.id.diff
Sep 28 2025, 1:27 PM
Subscribers
None

Details

Summary

Ref T13490. Historically, "arc" was eager to load external libraries from many locations. I plan to make this significantly more structured/safer in the future (see T5055), but this rule got dropped as the "experimental" and "wilds" branches collapsed to "master".

Restore "next to arcanist" and "inside externals/includes" as valid search locations for classic workflows.

Test Plan

Ran "arc" commands in a working copy with a "load" library configured.

Diff Detail

Repository
rARC Arcanist
Branch
path1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23867
Build 32836: Run Core Tests
Build 32835: arc lint + arc unit