Page MenuHomePhabricator

Fix an issue with 1up diff block rendering for added or removed blocks
ClosedPublic

Authored by epriestley on Nov 8 2019, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:48 AM
Unknown Object (File)
Thu, May 2, 6:10 AM
Unknown Object (File)
Mon, Apr 29, 2:18 AM
Unknown Object (File)
Sun, Apr 28, 1:21 PM
Unknown Object (File)
Fri, Apr 26, 3:52 PM
Unknown Object (File)
Thu, Apr 25, 2:37 AM
Unknown Object (File)
Sat, Apr 20, 9:48 PM
Unknown Object (File)
Fri, Apr 19, 5:23 PM
Subscribers

Details

Summary

Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render null as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan

Screen Shot 2019-11-08 at 7.36.31 AM.png (492×1 px, 76 KB)

Diff Detail

Repository
rP Phabricator
Branch
1up
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23637
Build 32493: Run Core Tests
Build 32492: arc lint + arc unit