Page MenuHomePhabricator

Fix an issue with 1up diff block rendering for added or removed blocks
ClosedPublic

Authored by epriestley on Nov 8 2019, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 5:28 AM
Unknown Object (File)
Wed, Feb 28, 2:07 AM
Unknown Object (File)
Feb 3 2024, 11:25 PM
Unknown Object (File)
Jan 23 2024, 11:54 PM
Unknown Object (File)
Jan 23 2024, 8:56 AM
Unknown Object (File)
Dec 25 2023, 11:32 AM
Unknown Object (File)
Dec 21 2023, 1:24 AM
Unknown Object (File)
Dec 15 2023, 7:25 AM
Subscribers

Details

Summary

Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render null as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan

Screen Shot 2019-11-08 at 7.36.31 AM.png (492×1 px, 76 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable