Page MenuHomePhabricator

Fix an issue with 1up diff block rendering for added or removed blocks
ClosedPublic

Authored by epriestley on Nov 8 2019, 3:35 PM.
Tags
None
Referenced Files
F19142347: D20897.id.diff
Wed, Dec 10, 1:44 PM
F19083122: D20897.id49810.diff
Tue, Dec 2, 12:30 PM
F19058242: D20897.id49810.diff
Sat, Nov 29, 1:24 AM
F19041053: D20897.id.diff
Wed, Nov 26, 2:25 PM
F19032106: D20897.diff
Tue, Nov 25, 4:24 AM
F19000863: D20897.id49809.diff
Nov 21 2025, 12:57 AM
F18999324: D20897.id49809.diff
Nov 20 2025, 8:52 PM
F18985272: D20897.id49809.diff
Nov 17 2025, 12:57 PM
Subscribers

Details

Summary

Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render null as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan

Screen Shot 2019-11-08 at 7.36.31 AM.png (492×1 px, 76 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable