Page MenuHomePhabricator

Fix an issue with 1up diff block rendering for added or removed blocks
ClosedPublic

Authored by epriestley on Nov 8 2019, 3:35 PM.
Tags
None
Referenced Files
F19932864: D20897.id49809.diff
Fri, Apr 10, 8:53 PM
F19932863: D20897.id49810.diff
Fri, Apr 10, 8:53 PM
F19932710: D20897.diff
Fri, Apr 10, 7:44 PM
F19909400: D20897.diff
Thu, Apr 2, 12:34 AM
F19882268: D20897.id49810.diff
Thu, Mar 19, 8:27 AM
F19827584: D20897.id49809.diff
Mar 9 2026, 10:31 AM
F19827000: D20897.id49809.diff
Mar 9 2026, 4:39 AM
F19826183: D20897.id.diff
Mar 8 2026, 5:53 PM
Subscribers

Details

Summary

Ref T13425. When a change adds or removes a block (vs adding or removing a document, or changing a block), we currently try to render null as cell content in the unified view. Make this check broader to catch both "no opposite document" and "no opposite cell".

Test Plan

Screen Shot 2019-11-08 at 7.36.31 AM.png (492×1 px, 76 KB)

Diff Detail

Repository
rP Phabricator
Branch
1up
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23637
Build 32493: Run Core Tests
Build 32492: arc lint + arc unit