Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F13167080: D20843.diff
Tue, May 7, 6:55 AM
Unknown Object (File)
Mon, May 6, 4:11 PM
Unknown Object (File)
Fri, May 3, 4:34 AM
Unknown Object (File)
Sun, Apr 28, 7:28 PM
Unknown Object (File)
Fri, Apr 26, 5:45 PM
Unknown Object (File)
Fri, Apr 26, 9:03 AM
Unknown Object (File)
Thu, Apr 25, 12:37 AM
Unknown Object (File)
Thu, Apr 11, 8:31 AM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable