Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 3:24 AM
Unknown Object (File)
Sat, Mar 16, 1:36 AM
Unknown Object (File)
Feb 18 2024, 7:47 PM
Unknown Object (File)
Feb 12 2024, 7:58 AM
Unknown Object (File)
Feb 6 2024, 2:42 PM
Unknown Object (File)
Feb 3 2024, 11:17 PM
Unknown Object (File)
Jan 18 2024, 8:37 PM
Unknown Object (File)
Dec 23 2023, 1:33 AM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable