Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F19241909: D20843.id49695.diff
Sun, Dec 21, 10:43 PM
F19083089: D20843.id49695.diff
Tue, Dec 2, 12:30 PM
F19058887: D20843.diff
Sat, Nov 29, 3:35 AM
F19035008: D20843.diff
Tue, Nov 25, 3:52 PM
F18985238: D20843.id49687.diff
Nov 17 2025, 12:56 PM
F18871535: D20843.id49687.diff
Nov 4 2025, 11:16 PM
F18858128: D20843.id49695.diff
Nov 1 2025, 8:53 PM
F18827951: D20843.id.diff
Oct 24 2025, 1:16 PM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23514
Build 32316: Run Core Tests
Build 32315: arc lint + arc unit