Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F15413962: D20843.diff
Wed, Mar 19, 10:14 PM
F15413068: D20843.id.diff
Wed, Mar 19, 4:54 PM
F15373491: D20843.id49687.diff
Wed, Mar 12, 4:26 PM
Unknown Object (File)
Feb 9 2025, 8:13 AM
Unknown Object (File)
Feb 9 2025, 8:13 AM
Unknown Object (File)
Feb 9 2025, 8:13 AM
Unknown Object (File)
Feb 9 2025, 1:01 AM
Unknown Object (File)
Feb 1 2025, 3:55 AM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable