Page MenuHomePhabricator

Improve sequencing of various content/header checks in abstract block diffs
ClosedPublic

Authored by epriestley on Sep 27 2019, 8:18 PM.
Tags
None
Referenced Files
F15469303: D20843.id49695.diff
Fri, Apr 4, 11:51 AM
F15462768: D20843.id49695.diff
Tue, Apr 1, 5:34 PM
F15449616: D20843.id49695.diff
Fri, Mar 28, 11:17 AM
F15449615: D20843.id49687.diff
Fri, Mar 28, 11:17 AM
F15449053: D20843.diff
Fri, Mar 28, 8:22 AM
F15437906: D20843.id49695.diff
Tue, Mar 25, 10:04 PM
F15423830: D20843.diff
Sat, Mar 22, 6:45 PM
F15413962: D20843.diff
Wed, Mar 19, 10:14 PM
Subscribers
None

Details

Summary

Ref T13425. Some diff checks currently sequence incorrectly:

  • When we're rendering block lists, syntax highlighting isn't relevant.
  • The "large change" guard can prevent rendering of otherwise-renderable changes.
  • Actual errors in the document engine (like bad JSON in a ".ipynb" file) aren't surfaced properly.

Improve sequencing somewhat to resolve these issues.

Test Plan
  • Viewed a notebook, no longer saw a "highlighting disabled" warning.
  • Forced a notebook to fail, got a useful inline error instead of a popup dialog error.
  • Forced a notebook to have a large number of differences, got a rendering out of it.

Diff Detail

Repository
rP Phabricator
Branch
jupyter1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23514
Build 32316: Run Core Tests
Build 32315: arc lint + arc unit