Tags

None

Referenced Files

	F15478174: D20839.id49680.diff
	Mon, Apr 7, 8:56 PM

	F15478173: D20839.id49670.diff
	Mon, Apr 7, 8:56 PM

	F15478172: D20839.id.diff
	Mon, Apr 7, 8:56 PM

	F15472857: D20839.id.diff
	Sat, Apr 5, 5:03 PM

	F15469780: D20839.id49680.diff
	Fri, Apr 4, 4:35 PM

	F15469779: D20839.id49670.diff
	Fri, Apr 4, 4:35 PM

	F15469778: D20839.id.diff
	Fri, Apr 4, 4:35 PM

	F15469361: D20839.diff
	Fri, Apr 4, 12:23 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes
Commits: rP884cd74cc4a5: In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better

Summary

Depends on D20838. Fixes T13414. Instead of doing coarse diffing with "PhutilEditDistanceMatrix", use hash-and-diff with "DocumentEngine".

Test Plan

On a large document (~3K top level blocks), saw a more sensible diff, instead of the whole thing falling back to "everything changed" mode.
On a small document, still saw a sensible granular diff.

Screen Shot 2019-09-25 at 2.55.12 PM.png (699×849 px, 190 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 25 2019, 10:12 PM

Harbormaster completed remote builds in B23497: Diff 49670.Sep 25 2019, 10:14 PM

epriestley requested review of this revision.Sep 25 2019, 10:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:50 PM

Closed by commit rP884cd74cc4a5: In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP884cd74cc4a5: In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better.

In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 49680

src/__phutil_library_map__.php

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php

src/infrastructure/diff/prose/tests/PhutilProseDiffTestCase.php

In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale betterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49680

src/__phutil_library_map__.php

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

src/infrastructure/diff/prose/PhutilProseDifferenceEngine.php

src/infrastructure/diff/prose/__tests__/PhutilProseDiffTestCase.php

In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/diff/prose/tests/PhutilProseDiffTestCase.php