Differential D20721

Update Phortune subscriptions for modern infrastructure
ClosedPublic
Actions

Authored by epriestley on Aug 17 2019, 2:51 AM.

Details

Reviewers: None
Maniphest Tasks: T13366: Update Phortune to work better with "enterprise" billing/accounts departments
Commits: rPa542024b6334: Update Phortune subscriptions for modern infrastructure

Summary

Depends on D20720. Ref T13366.

Use modern policies and policy interfaces.
Use new merchant authority cache.
Add (some) transactions.
Move MFA from pre-upgrade-gate to post-one-shot-check.
Simplify the autopay workflow.
Use the "reloading arrows" icon for subscriptions more consistently.

Test Plan

As a merchant-authority and account-authority, viewed, edited, and changed autopay for subscriptions.

Diff Detail

Repository

rP Phabricator

Branch

merchant10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23263
Build 31961: Run Core Tests
Build 31960: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 17 2019, 2:51 AM

Owners added a subscriber: Restricted Owners Package.Aug 17 2019, 2:51 AM

Harbormaster completed remote builds in B23263: Diff 49403.Aug 17 2019, 2:52 AM

epriestley requested review of this revision.Aug 17 2019, 2:52 AM

epriestley added a child revision: D20732: Update Charge and Cart policies in Phortune, and make URIs more consistent.Aug 22 2019, 9:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 4:07 AM

Closed by commit rPa542024b6334: Update Phortune subscriptions for modern infrastructure (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa542024b6334: Update Phortune subscriptions for modern infrastructure.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20190816.subscription.01.xaction.sql

19 lines

src/

__phutil_library_map__.php

applications/

phortune/

application/

PhabricatorPhortuneApplication.php

16 lines

codex/

PhortunePaymentMethodPolicyCodex.php

1 line

	PhortuneSubscriptionPolicyCodex.php
	PhortunePaymentMethodPolicyCodex.php

7 lines

controller/

account/

	PhortuneAccountPaymentMethodController.php
	PhortuneAccountPaymentMethodListController.php

2 lines

PhortuneAccountPaymentMethodListController.php

PhortuneAccountSubscriptionAutopayController.php

137 lines

PhortuneAccountSubscriptionViewController.php

338 lines

paymentmethod/

PhortunePaymentMethodDisableController.php

41 lines

subscription/

PhortuneSubscriptionViewController.php

editor/

PhortuneSubscriptionEditor.php

18 lines

phid/

PhortunePaymentMethodPHIDType.php

6 lines

PhortuneSubscriptionPHIDType.php

8 lines

query/

PhortuneSubscriptionTransactionQuery.php

10 lines

storage/

PhortunePaymentMethod.php

1 line

PhortuneSubscription.php

78 lines

PhortuneSubscriptionTransaction.php

18 lines

xaction/

subscription/

PhortuneSubscriptionAutopayTransaction.php

41 lines

PhortuneSubscriptionTransactionType.php

4 lines

Diff 49403

View Options

resources/sql/autopatches/20190816.subscription.01.xaction.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

View Options

src/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php

View Options

src/applications/phortune/codex/PhortuneSubscriptionPolicyCodex.php

View Options

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodListController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionAutopayController.php

View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php

View Options

src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodDisableController.php

View Options

src/applications/phortune/controller/subscription/PhortuneSubscriptionViewController.php

View Options

src/applications/phortune/editor/PhortuneSubscriptionEditor.php

View Options

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

View Options

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

View Options

src/applications/phortune/query/PhortuneSubscriptionTransactionQuery.php

View Options

src/applications/phortune/storage/PhortunePaymentMethod.php

View Options

src/applications/phortune/storage/PhortuneSubscription.php

View Options

src/applications/phortune/storage/PhortuneSubscriptionTransaction.php

View Options

src/applications/phortune/xaction/subscription/PhortuneSubscriptionAutopayTransaction.php

View Options

src/applications/phortune/xaction/subscription/PhortuneSubscriptionTransactionType.php

Update Phortune subscriptions for modern infrastructureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49403

resources/sql/autopatches/20190816.subscription.01.xaction.sql

src/__phutil_library_map__.php

src/applications/phortune/application/PhabricatorPhortuneApplication.php

src/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php

src/applications/phortune/codex/PhortuneSubscriptionPolicyCodex.php

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodController.php

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodListController.php

src/applications/phortune/controller/account/PhortuneAccountSubscriptionAutopayController.php

src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php

src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodDisableController.php

src/applications/phortune/controller/subscription/PhortuneSubscriptionViewController.php

src/applications/phortune/editor/PhortuneSubscriptionEditor.php

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

src/applications/phortune/query/PhortuneSubscriptionTransactionQuery.php

src/applications/phortune/storage/PhortunePaymentMethod.php

src/applications/phortune/storage/PhortuneSubscription.php

src/applications/phortune/storage/PhortuneSubscriptionTransaction.php

src/applications/phortune/xaction/subscription/PhortuneSubscriptionAutopayTransaction.php

src/applications/phortune/xaction/subscription/PhortuneSubscriptionTransactionType.php

Update Phortune subscriptions for modern infrastructure
ClosedPublic
Actions

Revision Contents
Changeset List