Differential D20718

Update PhortunePaymentMethod for modern policy interfaces
ClosedPublic
Actions

Authored by epriestley on Aug 16 2019, 5:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13366: Update Phortune to work better with "enterprise" billing/accounts departments
Commits: rPc4e0ac4d2783: Update PhortunePaymentMethod for modern policy interfaces

Summary

Depends on D20717. Ref T13366. Make PhortunePaymentMethod use an extended policy interface for consistency with modern approaches. Since Accounts have hard-coded policy behavior (and can't have object policies like "Subscribers") this should have no actual impact on program behavior.

This leaves one weird piece in the policy dialog UIs, see T13381.

Test Plan

Viewed and edited payment methods as a merchant and account member. Merchants can only view, not edit.

Diff Detail

Repository

rP Phabricator

Branch

merchant7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23260
Build 31955: Run Core Tests
Build 31954: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 16 2019, 5:08 PM

Harbormaster completed remote builds in B23259: Diff 49399.Aug 16 2019, 5:10 PM

epriestley requested review of this revision.Aug 16 2019, 5:10 PM

This is actually slightly tricky.

Since payment methods are bound to a particular merchant, we only want to let merchants view payment methods associated with their own merchant account.

Tweak the implementation to align around this.

epriestley added inline comments.Aug 16 2019, 5:30 PM