Page MenuHomePhabricator

Update PhortunePaymentMethod for modern policy interfaces
ClosedPublic

Authored by epriestley on Aug 16 2019, 5:08 PM.

Details

Summary

Depends on D20717. Ref T13366. Make PhortunePaymentMethod use an extended policy interface for consistency with modern approaches. Since Accounts have hard-coded policy behavior (and can't have object policies like "Subscribers") this should have no actual impact on program behavior.

This leaves one weird piece in the policy dialog UIs, see T13381.

Test Plan

Viewed and edited payment methods as a merchant and account member. Merchants can only view, not edit.

Diff Detail

Repository
rP Phabricator
Branch
merchant7
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23259
Build 31953: Run Core Tests
Build 31952: arc lint + arc unit

Event Timeline

This is actually slightly tricky.

Since payment methods are bound to a particular merchant, we only want to let merchants view payment methods associated with their own merchant account.

Tweak the implementation to align around this.

src/applications/policy/codex/PhabricatorPolicyCodex.php
47–55

(I couldn't find any callers for this anywhere.)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 4:03 AM
This revision was automatically updated to reflect the committed changes.