Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:08 AM
Unknown Object (File)
Mon, Apr 29, 11:03 AM
Unknown Object (File)
Sat, Apr 27, 2:31 PM
Unknown Object (File)
Fri, Apr 26, 7:33 PM
Unknown Object (File)
Mon, Apr 22, 8:55 PM
Unknown Object (File)
Fri, Apr 19, 3:15 AM
Unknown Object (File)
Fri, Apr 19, 3:15 AM
Unknown Object (File)
Fri, Apr 19, 3:15 AM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Branch
oauth1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23074
Build 31674: Run Core Tests
Build 31673: arc lint + arc unit