Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
F13050891: D20624.id49213.diff
Fri, Apr 19, 3:15 AM
F13050890: D20624.id49205.diff
Fri, Apr 19, 3:15 AM
F13050889: D20624.id.diff
Fri, Apr 19, 3:15 AM
Unknown Object (File)
Wed, Apr 17, 2:55 PM
Unknown Object (File)
Thu, Apr 11, 4:22 AM
Unknown Object (File)
Sat, Mar 30, 8:17 AM
Unknown Object (File)
Sat, Mar 30, 8:17 AM
Unknown Object (File)
Sat, Mar 30, 8:16 AM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable