Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
F15415646: D20624.id49205.diff
Thu, Mar 20, 7:09 AM
F15413695: D20624.id49213.diff
Wed, Mar 19, 8:37 PM
F15400211: D20624.diff
Mon, Mar 17, 10:21 AM
F15382493: D20624.diff
Fri, Mar 14, 12:41 PM
F15336202: D20624.diff
Sat, Mar 8, 6:29 PM
Unknown Object (File)
Mon, Mar 3, 10:38 AM
Unknown Object (File)
Fri, Feb 21, 1:51 PM
Unknown Object (File)
Tue, Feb 18, 8:30 AM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Branch
oauth1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23074
Build 31674: Run Core Tests
Build 31673: arc lint + arc unit