Page MenuHomePhabricator

Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button
ClosedPublic

Authored by epriestley on Jun 29 2019, 3:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 12:33 PM
Unknown Object (File)
Tue, Jan 21, 3:29 PM
Unknown Object (File)
Dec 21 2024, 3:06 PM
Unknown Object (File)
Dec 17 2024, 6:18 AM
Unknown Object (File)
Dec 9 2024, 8:58 PM
Unknown Object (File)
Dec 5 2024, 11:38 AM
Unknown Object (File)
Dec 5 2024, 10:39 AM
Unknown Object (File)
Nov 28 2024, 4:26 AM
Subscribers
None

Details

Summary

Ref T13330. Handles for "OAuthServerClient" objects currently do not have a URI, which causes some obscure fallout like a missing "Close" button when examining their transactions.

Add a URI.

Test Plan
  • Viewed an OAuth server client detail page.
  • Edited a policy, changing it to a custom policy.
  • Clicked "Custom Policy" in the resulting transaction to view a dialog explaining the changes.
  • Before change: dialog has no close button.
  • After change: dialog has a close button.

Screen Shot 2019-06-29 at 8.25.52 AM.png (1×1 px, 236 KB)

Diff Detail

Repository
rP Phabricator
Branch
oauth1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23074
Build 31674: Run Core Tests
Build 31673: arc lint + arc unit