Page MenuHomePhabricator
Differential D20597

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 1:08 AM
Unknown Object (File)
Sun, Feb 9, 9:12 AM
Unknown Object (File)
Fri, Jan 31, 9:15 PM
Unknown Object (File)
Fri, Jan 31, 2:35 PM
Unknown Object (File)
Wed, Jan 22, 11:29 PM
Unknown Object (File)
Tue, Jan 21, 7:52 PM
Unknown Object (File)
Tue, Jan 21, 3:57 PM
Unknown Object (File)
Tue, Jan 21, 11:45 AM
View All Files
Subscribers
None
Tokens
"Pterodactyl" token, awarded by yelirekim.

Details

Reviewers
amckinley
Maniphest Tasks
T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological"
Commits
rPHU674d69718e88: (stable) Promote 2019 Week 25
rPHU8eaf1b38d417: Replace made-up use of "topographical" ordering with professional, high-quality…
Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
utils/
24 lines
__tests__/
22 lines

Diff 49148

View Options

src/utils/AbstractDirectedGraph.php

Loading...
View Options

src/utils/__tests__/AbstractDirectedGraphTestCase.php

Loading...
Phabricator · Built by Phacility