Page MenuHomePhabricator

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic

Authored by epriestley on Jun 20 2019, 7:05 PM.
Tags
None
Referenced Files
F19854596: D20597.diff
Mar 13 2026, 9:50 AM
F19796586: D20597.id49148.diff
Feb 27 2026, 4:30 PM
F19795750: D20597.id49148.diff
Feb 27 2026, 3:37 AM
F19795749: D20597.id49148.diff
Feb 27 2026, 3:37 AM
F19550089: D20597.diff
Jan 27 2026, 5:48 PM
F19545142: D20597.diff
Jan 23 2026, 11:14 PM
F19505644: D20597.diff
Jan 9 2026, 1:09 PM
F19051935: D20597.diff
Nov 28 2025, 2:26 AM
Subscribers
None
Tokens
"Pterodactyl" token, awarded by yelirekim.

Details

Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable