Page MenuHomePhabricator

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic

Authored by epriestley on Jun 20 2019, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 7:50 PM
Unknown Object (File)
Sat, Mar 30, 8:11 AM
Unknown Object (File)
Thu, Mar 28, 3:11 PM
Unknown Object (File)
Wed, Mar 27, 12:28 AM
Unknown Object (File)
Tue, Mar 26, 7:14 PM
Unknown Object (File)
Tue, Mar 26, 7:14 PM
Unknown Object (File)
Tue, Mar 26, 7:14 PM
Unknown Object (File)
Sun, Mar 24, 6:31 AM
Subscribers
None
Tokens
"Pterodactyl" token, awarded by yelirekim.

Details

Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository
rPHU libphutil
Branch
topolog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23002
Build 31573: Run Core Tests
Build 31572: arc lint + arc unit