Page MenuHomePhabricator

Replace made-up use of "topographical" ordering with professional, high-quality academic use of "topological" ordering
ClosedPublic

Authored by epriestley on Jun 20 2019, 7:05 PM.
Tags
None
Referenced Files
F14087528: D20597.diff
Sat, Nov 23, 10:23 PM
Unknown Object (File)
Wed, Nov 20, 7:54 AM
Unknown Object (File)
Fri, Nov 15, 6:46 PM
Unknown Object (File)
Tue, Nov 12, 1:37 AM
Unknown Object (File)
Fri, Nov 8, 5:36 AM
Unknown Object (File)
Thu, Oct 31, 6:33 AM
Unknown Object (File)
Mon, Oct 28, 8:53 AM
Unknown Object (File)
Oct 24 2024, 12:10 AM
Subscribers
None
Tokens
"Pterodactyl" token, awarded by yelirekim.

Details

Summary

Ref T13325. See PHI1271. The word "topographical" is misused in a couple of APIs here when we mean "topological".

We also have a function which produces a "topological" ordering of a graph which may contain cycles, which isn't a real thing and can't really have a good name, but this is now "rough topological ordering".

Test Plan

Ran unit tests, grepped for topograph.

Diff Detail

Repository
rPHU libphutil
Branch
topolog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23002
Build 31573: Run Core Tests
Build 31572: arc lint + arc unit