Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic
Actions

Authored by joshuaspence on May 16 2019, 1:57 AM.

Tags

None

Referenced Files

	F14121678: D20523.id48931.diff
	Fri, Nov 29, 1:41 PM

	Unknown Object (File)
	Tue, Nov 19, 12:52 PM

	Unknown Object (File)
	Fri, Nov 15, 11:02 AM

	Unknown Object (File)
	Mon, Nov 11, 7:02 AM

	Unknown Object (File)
	Thu, Nov 7, 3:02 AM

	Unknown Object (File)
	Mon, Nov 4, 10:42 AM

	Unknown Object (File)
	Mon, Nov 4, 10:42 AM

	Unknown Object (File)
	Mon, Nov 4, 10:42 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A