Page MenuHomePhabricator

Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic

Authored by joshuaspence on May 16 2019, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 12:50 AM
Unknown Object (File)
Sat, Mar 23, 12:50 AM
Unknown Object (File)
Sat, Mar 23, 12:50 AM
Unknown Object (File)
Sat, Mar 16, 11:11 AM
Unknown Object (File)
Fri, Mar 1, 5:23 AM
Unknown Object (File)
Feb 21 2024, 1:42 PM
Unknown Object (File)
Feb 12 2024, 2:30 PM
Unknown Object (File)
Feb 3 2024, 10:30 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
lint5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22905
Build 31424: Run Core Tests
Build 31423: arc lint + arc unit