Differential D20528

Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules
ClosedPublic
Actions

Authored by epriestley on May 20 2019, 6:23 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion

Commits

rPf4201593808d: Implement Asana and JIRA external links via HyperlinkEngineExtension, not…

Summary

Depends on D20527. Ref T13291. Now that we have more flexible support for URI rewriting, use it for Doorkeeper URIs.

These are used when you set up Asana or JIRA and include the URI to an Asana task or a JIRA issue in a comment.

Test Plan

Linked up to Asana and JIRA.
Put Asana and JIRA URIs in comments.
Saw the UI update to pull task titles from Asana / JIRA using my OAuth credentials.

Diff Detail

Repository

rP Phabricator

Branch

doorkeeper1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/doorkeeper/engine/DoorkeeperURIRef.php:79	XHP62	Class Name Literal

Unit

Tests Passed

Build Status

Buildable 22831
Build 31317: Run Core Tests
Build 31316: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2019, 6:23 PM

Harbormaster completed remote builds in B22831: Diff 48955.May 20 2019, 6:24 PM

epriestley requested review of this revision.May 20 2019, 6:24 PM

epriestley added a child revision: D20530: Add a 15-second timeout to external service calls to fill Doorkeeper link tags.May 20 2019, 6:45 PM

amckinley accepted this revision.May 21 2019, 5:54 PM

This revision is now accepted and ready to land.May 21 2019, 5:54 PM

Closed by commit rPf4201593808d: Implement Asana and JIRA external links via HyperlinkEngineExtension, not… (authored by epriestley). · Explain WhyMay 21 2019, 7:15 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf4201593808d: Implement Asana and JIRA external links via HyperlinkEngineExtension, not….

epriestley mentioned this in D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes.Jun 17 2019, 5:40 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

auth/

provider/

PhabricatorAsanaAuthProvider.php

26 lines

PhabricatorJIRAAuthProvider.php

37 lines

doorkeeper/

application/

PhabricatorDoorkeeperApplication.php

7 lines

engine/

DoorkeeperURIRef.php

91 lines

engineextension/

DoorkeeperHyperlinkEngineExtension.php

92 lines

interface/

DoorkeeperRemarkupURIInterface.php

7 lines

remarkup/

DoorkeeperAsanaRemarkupRule.php

DoorkeeperJIRARemarkupRule.php

DoorkeeperRemarkupRule.php

Diff 48955

View Options

src/__phutil_library_map__.php

View Options

src/applications/auth/provider/PhabricatorAsanaAuthProvider.php

View Options

src/applications/auth/provider/PhabricatorJIRAAuthProvider.php

View Options

src/applications/doorkeeper/application/PhabricatorDoorkeeperApplication.php

View Options

src/applications/doorkeeper/engine/DoorkeeperURIRef.php

View Options

src/applications/doorkeeper/engineextension/DoorkeeperHyperlinkEngineExtension.php

View Options

src/applications/doorkeeper/interface/DoorkeeperRemarkupURIInterface.php

View Options

src/applications/doorkeeper/remarkup/DoorkeeperAsanaRemarkupRule.php

View Options

src/applications/doorkeeper/remarkup/DoorkeeperJIRARemarkupRule.php

View Options

src/applications/doorkeeper/remarkup/DoorkeeperRemarkupRule.php

Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rulesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48955

src/__phutil_library_map__.php

src/applications/auth/provider/PhabricatorAsanaAuthProvider.php

src/applications/auth/provider/PhabricatorJIRAAuthProvider.php

src/applications/doorkeeper/application/PhabricatorDoorkeeperApplication.php

src/applications/doorkeeper/engine/DoorkeeperURIRef.php

src/applications/doorkeeper/engineextension/DoorkeeperHyperlinkEngineExtension.php

src/applications/doorkeeper/interface/DoorkeeperRemarkupURIInterface.php

src/applications/doorkeeper/remarkup/DoorkeeperAsanaRemarkupRule.php

src/applications/doorkeeper/remarkup/DoorkeeperJIRARemarkupRule.php

src/applications/doorkeeper/remarkup/DoorkeeperRemarkupRule.php

Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules
ClosedPublic
Actions

Revision Contents
Changeset List