Page MenuHomePhabricator

Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules
ClosedPublic

Authored by epriestley on May 20 2019, 6:23 PM.

Details

Summary

Depends on D20527. Ref T13291. Now that we have more flexible support for URI rewriting, use it for Doorkeeper URIs.

These are used when you set up Asana or JIRA and include the URI to an Asana task or a JIRA issue in a comment.

Test Plan
  • Linked up to Asana and JIRA.
  • Put Asana and JIRA URIs in comments.
  • Saw the UI update to pull task titles from Asana / JIRA using my OAuth credentials.

Diff Detail

Repository
rP Phabricator
Branch
doorkeeper1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/doorkeeper/engine/DoorkeeperURIRef.php:79XHP62Class Name Literal
Unit
Tests Passed
Build Status
Buildable 22831
Build 31317: Run Core Tests
Build 31316: arc lint + arc unit