Paths

Table of Contentst

Differential D19730

Allow `buildFutures` and `resolveFutures` to be overridden
ClosedPublic
Actions

Authored by joshuaspence on Oct 4 2018, 12:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 2, 11:41 PM

	Unknown Object (File)
	Wed, Jul 1, 5:02 AM

	Unknown Object (File)
	Wed, Jul 1, 5:02 AM

	Unknown Object (File)
	Tue, Jun 30, 9:23 AM

	Unknown Object (File)
	Tue, Jun 30, 3:10 AM

	Unknown Object (File)
	Thu, Jun 25, 11:38 AM

	Unknown Object (File)
	Thu, Jun 25, 11:38 AM

	Unknown Object (File)
	Wed, Jun 17, 11:26 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22789
Build 31265: Run Core Tests
Build 31264: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Oct 4 2018, 12:02 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 4 2018, 12:02 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 4 2018, 12:02 AM

Harbormaster failed remote builds in B20987: Diff 47147!

joshuaspence mentioned this in D17350: Allow external linters to operate on multiple paths in batches.Oct 4 2018, 12:18 AM

Rebase

joshuaspence edited the summary of this revision. (Show Details)May 14 2019, 12:31 AM

Harbormaster completed remote builds in B22789: Diff 48916.May 14 2019, 12:32 AM

joshuaspence requested review of this revision.May 14 2019, 12:32 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 14 2019, 12:32 AM

epriestley accepted this revision.May 14 2019, 2:21 PM

This revision is now accepted and ready to land.May 14 2019, 2:21 PM

Thanks for the reviews :)

Closed by commit rARC6a8e76db329e: Allow `buildFutures` and `resolveFutures` to be overridden (authored by joshuaspence). · Explain WhyMay 14 2019, 11:10 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added an edge: rARC6a8e76db329e: Allow `buildFutures` and `resolveFutures` to be overridden.

joshuaspence mentioned this in D20523: Add a hook method that is called after `ArcanistLinter::setEngine`.May 16 2019, 1:57 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistExternalLinter.php

4 lines

Diff 48916

src/lint/linter/ArcanistExternalLinter.php

Loading...