Allow `buildFutures` and `resolveFutures` to be overridden
ClosedPublic
Actions

Authored by joshuaspence on Oct 4 2018, 12:02 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

	Time	Test
	639 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("") In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
	609 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at ArcanistLinterTestCase.php:168): Some linters failed: - CommandException: Command failed with error #1! COMMAND
	3,157 ms	ArcanistRuboCopLinterTestCase::Unknown Unit Message ("") In 'warning.lint-test', expected lint to raise warning on line 1 at char 11, but no warning was raised. Actually raised: No messages.
	81 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("") 5 assertions passed.
	18 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (3 Failed · 25 Passed · 27 Skipped)