Page MenuHomePhabricator

Allow `buildFutures` and `resolveFutures` to be overridden
ClosedPublic

Authored by joshuaspence on Oct 4 2018, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:56 AM
Unknown Object (File)
Tue, Nov 26, 5:50 PM
Unknown Object (File)
Nov 22 2024, 7:16 PM
Unknown Object (File)
Nov 18 2024, 1:44 PM
Unknown Object (File)
Nov 14 2024, 11:21 PM
Unknown Object (File)
Nov 14 2024, 12:40 AM
Unknown Object (File)
Nov 10 2024, 11:54 AM
Unknown Object (File)
Nov 10 2024, 2:32 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22789
Build 31265: Run Core Tests
Build 31264: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 4 2018, 12:02 AM
Harbormaster failed remote builds in B20987: Diff 47147!
This revision is now accepted and ready to land.May 14 2019, 2:21 PM