Page MenuHomePhabricator

Let the top-level exception handler dump a stack trace if we reach debug mode before things go sideways
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:10 PM.
Tags
None
Referenced Files
F15523031: D20142.diff
Sun, Apr 20, 11:11 PM
F15519452: D20142.id48086.diff
Sat, Apr 19, 11:13 PM
F15519307: D20142.id48103.diff
Sat, Apr 19, 9:35 PM
F15514132: D20142.id48099.diff
Fri, Apr 18, 12:48 AM
F15513971: D20142.id48099.diff
Thu, Apr 17, 11:27 PM
F15513580: D20142.id.diff
Thu, Apr 17, 8:03 PM
F15510862: D20142.diff
Wed, Apr 16, 9:35 PM
F15487390: D20142.id48086.diff
Thu, Apr 10, 1:34 PM
Subscribers
None
Tokens
"100" token, awarded by joshuaspence.

Details

Summary

Depends on D20140. Ref T13250. Currently, the top-level exception handler doesn't dump stacks because we might not be in debug mode, and we might double-extra-super fatal if we call PhabricatorEnv:... to try to figure out if we're in debug mode or not.

We can get around this by setting a flag on the Sink once we're able to confirm that we're in debug mode. Then it's okay for the top-level error handler to show traces.

There's still some small possibility that showing a trace could make us double-super-fatal since we have to call a little more code, but AphrontStackTraceView is pretty conservative about what it does and 99% of the time this is a huge improvement.

Test Plan

Screen Shot 2019-02-11 at 1.00.45 PM.png (1×1 px, 350 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/aphront/sink/AphrontHTTPSink.php
7–8

I just happened to notice this "do install" typo.

This revision is now accepted and ready to land.Feb 11 2019, 11:05 PM
  • Just remove that comment since we don't do either one, even though they're technically possible.
This revision was automatically updated to reflect the committed changes.