Page MenuHomePhabricator

Use "phutil_string_cast()" in TypeaheadDatasource
ClosedPublic

Authored by epriestley on Feb 11 2019, 6:51 PM.
Tags
None
Referenced Files
F18755213: D20140.id.diff
Sun, Oct 5, 4:20 AM
F18752879: D20140.diff
Sat, Oct 4, 4:41 PM
F18670291: D20140.diff
Wed, Sep 24, 11:41 PM
F18601229: D20140.diff
Sat, Sep 13, 11:52 AM
F18569387: D20140.id48094.diff
Wed, Sep 10, 1:36 AM
F18569385: D20140.id48081.diff
Wed, Sep 10, 1:36 AM
F18430388: D20140.id.diff
Aug 31 2025, 4:00 AM
F18420854: D20140.diff
Aug 30 2025, 4:38 PM
Subscribers
None

Details

Summary

Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.

Truly a great day for PHP.

(Eventually we may want to replace all (string) with phutil_string_cast(), but let's let it have some time in the wild first?)

Test Plan

Triggered the error, got a more useful exception behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable