Page MenuHomePhabricator

Use "phutil_string_cast()" in TypeaheadDatasource
ClosedPublic

Authored by epriestley on Feb 11 2019, 6:51 PM.

Details

Summary

Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.

Truly a great day for PHP.

(Eventually we may want to replace all (string) with phutil_string_cast(), but let's let it have some time in the wild first?)

Test Plan

Triggered the error, got a more useful exception behavior.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 11 2019, 6:51 PM
epriestley requested review of this revision.Feb 11 2019, 6:53 PM
amckinley accepted this revision.Feb 11 2019, 9:35 PM
This revision is now accepted and ready to land.Feb 11 2019, 9:35 PM
This revision was automatically updated to reflect the committed changes.