Page MenuHomePhabricator

Use "phutil_string_cast()" in TypeaheadDatasource
ClosedPublic

Authored by epriestley on Feb 11 2019, 6:51 PM.
Tags
None
Referenced Files
F18776894: D20140.id.diff
Fri, Oct 10, 11:59 PM
F18767452: D20140.id48094.diff
Tue, Oct 7, 10:35 PM
F18765271: D20140.id48081.diff
Tue, Oct 7, 10:29 AM
F18759266: D20140.diff
Mon, Oct 6, 2:46 AM
F18755213: D20140.id.diff
Sun, Oct 5, 4:20 AM
F18752879: D20140.diff
Sat, Oct 4, 4:41 PM
F18670291: D20140.diff
Sep 24 2025, 11:41 PM
F18601229: D20140.diff
Sep 13 2025, 11:52 AM
Subscribers
None

Details

Summary

Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.

Truly a great day for PHP.

(Eventually we may want to replace all (string) with phutil_string_cast(), but let's let it have some time in the wild first?)

Test Plan

Triggered the error, got a more useful exception behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable