Page MenuHomePhabricator

Use "phutil_string_cast()" in TypeaheadDatasource
ClosedPublic

Authored by epriestley on Feb 11 2019, 6:51 PM.
Tags
None
Referenced Files
F19293001: D20140.id48081.diff
Tue, Dec 23, 10:02 AM
F19141721: D20140.diff
Wed, Dec 10, 1:27 PM
F18906036: D20140.diff
Nov 8 2025, 4:38 PM
F18848801: D20140.id48081.diff
Oct 30 2025, 6:24 AM
F18834549: D20140.diff
Oct 26 2025, 9:28 AM
F18776894: D20140.id.diff
Oct 10 2025, 11:59 PM
F18767452: D20140.id48094.diff
Oct 7 2025, 10:35 PM
F18765271: D20140.id48081.diff
Oct 7 2025, 10:29 AM
Subscribers
None

Details

Summary

Depends on D20138. Ref T13250. This improves exception behavior and gives us a standard page with a stack trace instead of a text fatal with no stack trace.

Truly a great day for PHP.

(Eventually we may want to replace all (string) with phutil_string_cast(), but let's let it have some time in the wild first?)

Test Plan

Triggered the error, got a more useful exception behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable