Page MenuHomePhabricator

Try harder to present display/rendering exceptions to the user using standard exception handling
ClosedPublic

Authored by epriestley on Feb 11 2019, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 10:43 AM
Unknown Object (File)
Thu, Jun 23, 11:19 PM
Unknown Object (File)
Wed, Jun 22, 11:06 PM
Unknown Object (File)
Fri, Jun 17, 10:19 AM
Unknown Object (File)
Thu, Jun 16, 3:54 AM
Unknown Object (File)
Wed, Jun 15, 4:37 AM
Unknown Object (File)
Tue, Jun 14, 4:20 PM
Unknown Object (File)
Sun, Jun 12, 2:36 PM
Subscribers
None

Details

Summary

Ref T13250. When exceptions occur in display/rendering/writing, they currently go straight to the fallback handler. This is a minimal handler which doesn't show a stack trace or include any debugging details.

In some cases, we have to do this: some of these exceptions prevent us from building a normal page. For example, if the menu bar has a hard fatal in it, we aren't going to be able to build a nice exception page with a menu bar no matter how hard we try.

However, in many cases the error is mundane: something detected something invalid and raised an exception during rendering. In these cases there's no problem with the page chrome or the rendering pathway itself, just with rendering the page data.

When we get a rendering/response exception, try a second time to build a nice normal exception page. This will often work. If it doesn't work, fall back as before.

Test Plan

Screen Shot 2019-02-11 at 9.32.42 AM.png (1×2 px, 236 KB)

  • After:

Screen Shot 2019-02-11 at 9.36.53 AM.png (1×2 px, 520 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable