Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
F15415651: D19838.id47373.diff
Thu, Mar 20, 7:10 AM
F15382583: D19838.diff
Fri, Mar 14, 1:17 PM
Unknown Object (File)
Thu, Feb 20, 5:14 PM
Unknown Object (File)
Feb 20 2025, 1:53 AM
Unknown Object (File)
Feb 19 2025, 6:28 PM
Unknown Object (File)
Feb 18 2025, 3:44 PM
Unknown Object (File)
Feb 9 2025, 1:53 PM
Unknown Object (File)
Feb 9 2025, 6:42 AM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable