Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
F17751899: D19838.diff
Tue, Jul 22, 6:13 AM
Unknown Object (File)
Jun 30 2025, 2:37 PM
Unknown Object (File)
Jun 29 2025, 8:41 AM
Unknown Object (File)
Jun 27 2025, 11:26 AM
Unknown Object (File)
Jun 26 2025, 9:44 PM
Unknown Object (File)
May 10 2025, 8:03 AM
Unknown Object (File)
Apr 26 2025, 2:02 PM
Unknown Object (File)
Apr 22 2025, 9:48 AM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable