Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 1:24 PM
Unknown Object (File)
Thu, Oct 24, 11:51 AM
Unknown Object (File)
Oct 9 2024, 10:46 AM
Unknown Object (File)
Sep 20 2024, 9:19 PM
Unknown Object (File)
Sep 6 2024, 4:28 AM
Unknown Object (File)
Aug 28 2024, 10:24 PM
Unknown Object (File)
Aug 26 2024, 2:28 AM
Unknown Object (File)
Aug 25 2024, 8:11 AM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable