Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
F18984992: D19838.id47366.diff
Mon, Nov 17, 12:50 PM
F18863224: D19838.diff
Sun, Nov 2, 10:24 PM
F18733860: D19838.id.diff
Sep 30 2025, 10:43 PM
F18717646: D19838.diff
Sep 29 2025, 2:20 PM
F18648899: D19838.diff
Sep 20 2025, 5:50 PM
F18609179: D19838.diff
Sep 14 2025, 2:29 AM
F18594010: D19838.diff
Sep 12 2025, 4:42 PM
F18586038: D19838.diff
Sep 11 2025, 5:15 PM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable