Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
F15546133: D19838.id47366.diff
Sat, Apr 26, 2:02 PM
F15528218: D19838.diff
Tue, Apr 22, 9:48 AM
F15476173: D19838.id47366.diff
Mon, Apr 7, 4:34 AM
F15453456: D19838.id47373.diff
Mar 29 2025, 11:58 AM
F15451760: D19838.id47366.diff
Mar 28 2025, 11:40 PM
F15439394: D19838.id.diff
Mar 26 2025, 7:21 AM
F15438388: D19838.diff
Mar 26 2025, 12:28 AM
F15424201: D19838.id47366.diff
Mar 22 2025, 8:51 PM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable