Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
F19538242: D19838.diff
Wed, Jan 21, 2:41 PM
F19520335: D19838.id47366.diff
Fri, Jan 16, 12:59 PM
F19510491: D19838.id47366.diff
Sun, Jan 11, 10:27 AM
F19100268: D19838.id47373.diff
Dec 4 2025, 10:59 PM
F19082884: D19838.id47373.diff
Dec 2 2025, 12:27 PM
F18984992: D19838.id47366.diff
Nov 17 2025, 12:50 PM
F18863224: D19838.diff
Nov 2 2025, 10:24 PM
F18733860: D19838.id.diff
Sep 30 2025, 10:43 PM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable