Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Sun, Nov 25, 11:57 PM.

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sun, Nov 25, 11:57 PM
epriestley requested review of this revision.Sun, Nov 25, 11:58 PM
amckinley accepted this revision.Mon, Nov 26, 4:35 PM
This revision is now accepted and ready to land.Mon, Nov 26, 4:35 PM
This revision was automatically updated to reflect the committed changes.