Page MenuHomePhabricator

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file
ClosedPublic

Authored by epriestley on Nov 25 2018, 11:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:06 AM
Unknown Object (File)
Sat, Apr 20, 12:12 AM
Unknown Object (File)
Wed, Apr 17, 2:41 PM
Unknown Object (File)
Mar 27 2024, 12:36 PM
Unknown Object (File)
Mar 26 2024, 7:13 PM
Unknown Object (File)
Mar 21 2024, 5:25 AM
Unknown Object (File)
Mar 19 2024, 10:48 PM
Unknown Object (File)
Mar 4 2024, 6:51 AM
Subscribers
None

Details

Summary

Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan

Left an inline on the final line of a new file, saw it render properly in HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable