Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.
Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13216: 2018 Week 45-47 Bonus Content
- Commits
- rPbcc90d8c6b8c: Fix an off-by-one error affecting mail rendering of inlines on the final line…
Left an inline on the final line of a new file, saw it render properly in HTML mail.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- inlinemail1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21215 Build 28855: Run Core Tests Build 28854: arc lint + arc unit