Page MenuHomePhabricator

Make a Feed query construction less clever/sneaky for new qsprintf() semantics
ClosedPublic

Authored by epriestley on Nov 25 2018, 9:40 PM.

Details

Summary

Ref T13216. Ref T13217. Currently, we build this query in a weird way so we end up with (1, 2, 3) on both 32-bit and 64-bit systems.

I can't reproduce the string-vs-int MySQL key issue on any system I have access to, so just simplify this and format as ('1', '2', '3') instead.

The issue this is working around is that MySQL would (I think?) sometimes appear to do something goofy and miss the key if you formatted the query with strings. I never really nailed this down and could have either been mistaken about it or it could be fixed in all modern versions of MySQL. Until we have better evidence to the contrary, assume MySQL is smart enough to handle this sensibly now.

Test Plan

Ran daemons with Feed publish workers, no longer received query warnings.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 25 2018, 9:40 PM
epriestley requested review of this revision.Nov 25 2018, 9:42 PM
  • One typo fewer.
amckinley accepted this revision.Nov 26 2018, 6:33 PM
This revision is now accepted and ready to land.Nov 26 2018, 6:33 PM
This revision was automatically updated to reflect the committed changes.