Page MenuHomePhabricator
Differential D19808

Fix flickering tooltips in Chrome when the tip container overlaps the triggering element
ClosedPublic
Actions

Authored by epriestley on Nov 15 2018, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:26 PM
Unknown Object (File)
Tue, Dec 17, 6:41 AM
Unknown Object (File)
Mon, Dec 9, 5:07 PM
Unknown Object (File)
Mon, Dec 2, 10:18 PM
Unknown Object (File)
Sun, Dec 1, 6:35 PM
Unknown Object (File)
Thu, Nov 28, 4:31 AM
Unknown Object (File)
Nov 25 2024, 9:47 PM
Unknown Object (File)
Oct 10 2024, 10:17 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
avivey
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
T8440: Tooltip flicker at certain cursor positions
Commits
rPea6d2afa8685: Fix flickering tooltips in Chrome when the tip container overlaps the…
Summary

Fixes T8440. See that task for discussion.

Ref T13216. See PHI976.

Test Plan

In Chrome, hovered a timestamp and moved the mouse up to the "overlap" area (see T8440). Before: flickered like crazy. After: no flickering.

(I couldn't reproduce the original issue in modern Firefox or Safari.)

Diff Detail

Repository
rP Phabricator
Branch
flicker1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21159
Build 28768: Run Core Tests
Build 28767: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 15 2018, 12:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 15 2018, 12:06 PM
Harbormaster failed remote builds in B21157: Diff 47308!
epriestley updated this revision to Diff 47309.Nov 15 2018, 12:10 PM
  • Update Celerity map.
epriestley updated this revision to Diff 47310.Nov 15 2018, 12:11 PM
  • Slightly better comment text.
Harbormaster completed remote builds in B21158: Diff 47309.Nov 15 2018, 12:12 PM
Harbormaster completed remote builds in B21159: Diff 47310.
epriestley requested review of this revision.Nov 15 2018, 12:13 PM
epriestley edited the summary of this revision. (Show Details)Nov 15 2018, 12:16 PM
epriestley added a task: T13216: 2018 Week 45-47 Bonus Content.
epriestley edited the summary of this revision. (Show Details)
avivey accepted this revision.Nov 15 2018, 5:40 PM
This revision is now accepted and ready to land.Nov 15 2018, 5:40 PM
Closed by commit rPea6d2afa8685: Fix flickering tooltips in Chrome when the tip container overlaps the… (authored by epriestley). · Explain WhyNov 15 2018, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
webroot/
rsrc/
css/
aphront/
6 lines

Diff 47310

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/tooltip.css

Loading...
Phabricator · Built by Phacility