Page MenuHomePhabricator

Fix flickering tooltips in Chrome when the tip container overlaps the triggering element
ClosedPublic

Authored by epriestley on Nov 15 2018, 12:05 PM.
Tags
None
Referenced Files
F15393151: D19808.id47310.diff
Sat, Mar 15, 8:04 PM
F15383957: D19808.diff
Fri, Mar 14, 6:26 PM
F15381451: D19808.id47308.diff
Fri, Mar 14, 7:43 AM
F15380824: D19808.diff
Fri, Mar 14, 4:38 AM
Unknown Object (File)
Sun, Feb 23, 5:42 AM
Unknown Object (File)
Tue, Feb 18, 9:26 AM
Unknown Object (File)
Tue, Feb 18, 8:37 AM
Unknown Object (File)
Tue, Feb 18, 4:54 AM
Subscribers
None

Details

Summary

Fixes T8440. See that task for discussion.

Ref T13216. See PHI976.

Test Plan

In Chrome, hovered a timestamp and moved the mouse up to the "overlap" area (see T8440). Before: flickered like crazy. After: no flickering.

(I couldn't reproduce the original issue in modern Firefox or Safari.)

Diff Detail

Repository
rP Phabricator
Branch
flicker1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21157
Build 28764: Run Core Tests
Build 28763: arc lint + arc unit

Unit TestsFailed

TimeTest
238 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
2 assertions passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 352 Passed)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 15 2018, 12:06 PM
Harbormaster failed remote builds in B21157: Diff 47308!
  • Slightly better comment text.
This revision is now accepted and ready to land.Nov 15 2018, 5:40 PM
This revision was automatically updated to reflect the committed changes.