HomePhabricator

Improve performance of two recent commit migrations

Description

Improve performance of two recent commit migrations

Summary:
Ref T13216. See PHI959. These two recent migrations can be expressed more efficiently:

  • When updating commit audit statuses, the field isn't JSON encoded or anything so we can just issue several bulk UPDATEs.
  • When inserting mail keys, we can batch them in groups of 100.

Test Plan: Used bin/storage upgrade -f --apply phabricator:... to reapply patches. Saw equivalent behavior and faster runtimes.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13216

Differential Revision: https://secure.phabricator.com/D19802

Details

Provenance
epriestleyAuthored on Nov 14 2018, 5:41 PM
epriestleyPushed on Nov 15 2018, 11:52 AM
Reviewer
amckinley
Differential Revision
D19802: Improve performance of two recent commit migrations
Parents
rP86fd2041484f: Fix all query warnings in "arc unit --everything"
Branches
Unknown
Tags
Unknown
Tasks
T13216: 2018 Week 45-47 Bonus Content
Build Status
Buildable 21156
Build 28762: Run Core Tests