Page MenuHomePhabricator

Make qsprintf() return an object, not a string, to support %P and hardening of %Q
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:23 AM.
Tags
None
Referenced Files
F18368287: D19781.diff
Thu, Aug 28, 12:42 AM
F18169907: D19781.id47284.diff
Fri, Aug 15, 5:34 PM
F18095189: D19781.diff
Thu, Aug 7, 10:33 PM
F18081840: D19781.id47247.diff
Tue, Aug 5, 2:28 AM
F17957468: D19781.id.diff
Aug 1 2025, 6:18 AM
F17948548: D19781.diff
Jul 31 2025, 9:21 PM
F17940662: D19781.id47284.diff
Jul 31 2025, 4:39 AM
F17659857: D19781.id.diff
Jul 12 2025, 2:50 PM
Subscribers
None

Details

Summary

Ref T13217. Ref T13216. Previously, we changed csprintf() to return an object instead of a string to support %P for passwords. Prepare for a %P for qsprintf(...) too. T13217 discusses general plans here, although %P, %LA, %LO, and %LQ are not implemented yet.

This may be a little rocky, but the csprintf() change was generally fairly straightforward so I have reasonably high hopes about this one not being too terribly painful.

Test Plan

Loaded a Phabricator page -- which now generates hundreds of "unsafe query construction" errors, but still works.

Diff Detail

Repository
rPHU libphutil
Branch
qobject1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/xsprintf/qsprintf.php:300XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21096
Build 28670: Run Core Tests
Build 28669: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/xsprintf/qsprintf.php
200

Worth adding a "TODO" here to clean up later? Or is the conversion for this going to be effectively endless?

This revision is now accepted and ready to land.Nov 7 2018, 8:27 PM