Page MenuHomePhabricator

Make qsprintf() return an object, not a string, to support %P and hardening of %Q
ClosedPublic

Authored by epriestley on Nov 7 2018, 12:23 AM.
Tags
None
Referenced Files
F13090829: D19781.diff
Thu, Apr 25, 2:35 AM
Unknown Object (File)
Sun, Apr 21, 12:36 PM
Unknown Object (File)
Fri, Apr 19, 8:04 PM
Unknown Object (File)
Fri, Apr 19, 8:10 AM
Unknown Object (File)
Fri, Apr 19, 8:09 AM
Unknown Object (File)
Fri, Apr 19, 5:12 AM
Unknown Object (File)
Wed, Apr 17, 5:20 AM
Unknown Object (File)
Sun, Apr 14, 2:15 AM
Subscribers
None

Details

Summary

Ref T13217. Ref T13216. Previously, we changed csprintf() to return an object instead of a string to support %P for passwords. Prepare for a %P for qsprintf(...) too. T13217 discusses general plans here, although %P, %LA, %LO, and %LQ are not implemented yet.

This may be a little rocky, but the csprintf() change was generally fairly straightforward so I have reasonably high hopes about this one not being too terribly painful.

Test Plan

Loaded a Phabricator page -- which now generates hundreds of "unsafe query construction" errors, but still works.

Diff Detail

Repository
rPHU libphutil
Branch
qobject1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/xsprintf/qsprintf.php:300XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21096
Build 28670: Run Core Tests
Build 28669: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/xsprintf/qsprintf.php
200

Worth adding a "TODO" here to clean up later? Or is the conversion for this going to be effectively endless?

This revision is now accepted and ready to land.Nov 7 2018, 8:27 PM