Differential D19741

Let lint rules support anonymous classes
ClosedPublic
Actions

Authored by wjiang on Oct 10 2018, 12:04 AM.

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Summary

Ref T4334. Depends on D19740. Improve some lint rules so they can handle anonymous classes.

Test Plan

Ran updated tests

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21006
Build 28535: arc lint + arc unit

Event Timeline

wjiang created this revision.Oct 10 2018, 12:04 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 10 2018, 12:04 AM

Herald added a subscriber: epriestley. · View Herald Transcript

wjiang requested review of this revision.Oct 10 2018, 12:04 AM

Harbormaster completed remote builds in B21006: Diff 47163.Oct 10 2018, 12:04 AM

Maybe add some comments?

epriestley accepted this revision.May 14 2019, 2:19 PM

This revision is now accepted and ready to land.May 14 2019, 2:19 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 14 2019, 2:19 PM

Closed by commit rARC82445bb60534: Let lint rules support anonymous classes (authored by wjiang, committed by joshuaspence). · Explain WhyMay 15 2019, 1:11 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence added an edge: rARC82445bb60534: Let lint rules support anonymous classes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistClassNameLiteralXHPASTLinterRule.php

3 lines

ArcanistConstructorParenthesesXHPASTLinterRule.php

4 lines

ArcanistSelfClassReferenceXHPASTLinterRule.php

3 lines

ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

3 lines

__tests__/

class-name-literal/

class-name-literal.lint-test

12 lines

constructor-parentheses/

constructor-parentheses.lint-test

2 lines

self-class-reference/

self-class-references.lint-test

12 lines

unnecessary-final-modifier/

unnecessary-final-modifier.lint-test

1 line

Diff 47163

View Options

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/class-name-literal/class-name-literal.lint-test

View Options

src/lint/linter/xhpast/rules/tests/constructor-parentheses/constructor-parentheses.lint-test

View Options

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

View Options

src/lint/linter/xhpast/rules/tests/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

Let lint rules support anonymous classesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47163

src/lint/linter/xhpast/rules/ArcanistClassNameLiteralXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistConstructorParenthesesXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/class-name-literal/class-name-literal.lint-test

src/lint/linter/xhpast/rules/__tests__/constructor-parentheses/constructor-parentheses.lint-test

src/lint/linter/xhpast/rules/__tests__/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/__tests__/unnecessary-final-modifier/unnecessary-final-modifier.lint-test

Let lint rules support anonymous classes
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/class-name-literal/class-name-literal.lint-test

src/lint/linter/xhpast/rules/tests/constructor-parentheses/constructor-parentheses.lint-test

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-final-modifier/unnecessary-final-modifier.lint-test