Page MenuHomePhabricator
Differential D19674

Provide a convenient way to log arbitrary text in Drydock without needing structured log classes
ClosedPublic
Actions

Authored by epriestley on Sep 14 2018, 4:25 PM.
Tags
None
Referenced Files
F15445197: D19674.id47014.diff
Thu, Mar 27, 12:48 PM
F15441393: D19674.id.diff
Wed, Mar 26, 5:57 PM
F15436409: D19674.diff
Tue, Mar 25, 1:58 PM
F15431896: D19674.id47014.diff
Mon, Mar 24, 3:14 PM
F15403727: D19674.id47014.diff
Tue, Mar 18, 4:38 AM
F15385250: D19674.id.diff
Fri, Mar 14, 10:03 PM
F15332054: D19674.diff
Mar 7 2025, 4:26 PM
F15301967: D19674.id47027.diff
Mar 5 2025, 6:25 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T13197: 2018 Week 37 Bonus Content
Commits
rP0167f357b723: Provide a convenient way to log arbitrary text in Drydock without needing…
Summary

Depends on D19673. Ref T13197. See PHI873.

Test Plan

Added some code like this:

$operation->logText('Nice convenient text logging.');

...then got:

Screen Shot 2018-09-14 at 9.23.09 AM.png (976×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 14 2018, 4:25 PM
Owners added a subscriber: Restricted Owners Package.Sep 14 2018, 4:25 PM
Harbormaster completed remote builds in B20825: Diff 47014.Sep 14 2018, 4:26 PM
epriestley requested review of this revision.Sep 14 2018, 4:26 PM
amckinley accepted this revision.Sep 14 2018, 6:55 PM
amckinley added inline comments.
src/applications/drydock/logtype/DrydockTextLogType.php
4–11

What's the maximum amount of text you can dump into a log? Worth documenting here?

This revision is now accepted and ready to land.Sep 14 2018, 6:55 PM
epriestley added a comment.Sep 14 2018, 7:26 PM

I think any "reasonable" amount should be fine. Maybe I'm not being imaginative enough, of course...

Closed by commit rP0167f357b723: Provide a convenient way to log arbitrary text in Drydock without needing… (authored by epriestley). · Explain WhySep 15 2018, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
logtype/
27 lines
storage/
8 lines

Diff 47027

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/drydock/logtype/DrydockTextLogType.php

Loading...
View Options

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...
Phabricator · Built by Phacility